Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduces RPC error log to debug when domain-level RPC service returns an error (fixes #4579) #4611

Merged

Conversation

jorgeantonio21
Copy link
Contributor

@jorgeantonio21 jorgeantonio21 commented Sep 2, 2022

Description

The comms server code contains incorrect logs, as referred in #4579.

Motivation and Context

Fixes #4579.

How Has This Been Tested?
--- Log information

@jorgeantonio21 jorgeantonio21 marked this pull request as ready for review September 2, 2022 13:48
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@CjS77 CjS77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sdbondi sdbondi changed the title fix: remove suppressed bad logs (see issue #4579) fix: reduces RPC error log to debug for domain-level errors (fixes #4579) Sep 5, 2022
@sdbondi sdbondi changed the title fix: reduces RPC error log to debug for domain-level errors (fixes #4579) fix: reduces RPC error log to debug when domain-level RPC service returns an error (fixes #4579) Sep 5, 2022
Copy link
Collaborator

@stringhandler stringhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not 100% sure about this, but we can revert if needed

@stringhandler stringhandler merged commit 86c030d into tari-project:development Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce RPC error log to debug when domain-level RPC service returns an error
5 participants