fix: stop race condition in output encumbrance #4613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWvheerden
changed the title
stringhandler
previously approved these changes
Sep 5, 2022
SWvheerden
force-pushed
the
sw_add)output_mutex
branch
from
ad2d93e
to
238a8ec
Compare
Merged
stringhandler
pushed a commit
that referenced
this pull request
Sep 6, 2022
Description --- Removes mutex added in #4613 Motivation and Context --- While the race condition is definitely possible in code, all code from the OMS runs synchronously, as shown by the fact that almost all functions have `&mut self` and rust blocks mut borrow across threads. This means that there is no race condition possible as this is all called synchronously. How Has This Been Tested? ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a mutex to stop a race condition in the output manager error. Its possible that if more than on transactions happens in near the same time, the transactions will select the same inputs.
How Has This Been Tested?
Unit tests