fix: force wallet sqlite to do checkpoint after db decryption #4905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
force sqlite db to do checkpoint
|
Ah great so that was the problem? What does (2) mean? I do not see it in the docs |
CjS77
added
P-acks_required
stringhandler
approved these changes
Nov 9, 2022
CjS77
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Forces the database to do a checkpoint after the last step of the database decryption.
Motivation and Context
The mobile applications decrypt the SQLite wallet database, after which they copy it to a safe location to restore later.
If we run database decrypt, the actual database file might not yet have the changes applied to it, this forces a checkpoint which will ensure that the changes are committed to on file
How Has This Been Tested?
manual
Fixes: #4904