Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: input and output signatures #4983

Merged
merged 3 commits into from Dec 8, 2022
Merged

fix!: input and output signatures #4983

merged 3 commits into from Dec 8, 2022

Conversation

SWvheerden
Copy link
Collaborator

@SWvheerden SWvheerden commented Nov 30, 2022 •
edited

Description

Script and metadata signature now commit to version
Make sure Gen block checks signatures
Reset gen block

Motivation and Context

See: #4758

How Has This Been Tested?

Unit tests

BREAKING: This changes the challenge of both the script and metadata signatures

@SWvheerden
Copy link
Collaborator Author

Fixes: #4758

jorgeantonio21
jorgeantonio21 reviewed Dec 1, 2022
View reviewed changes
Copy link
Contributor

@jorgeantonio21 jorgeantonio21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@stringhandler stringhandler added the W-consensus_breaking Warn - A change requiring a hard fork to be activated label Dec 5, 2022
@stringhandler stringhandler merged commit a0f1d95 into tari-project:development Dec 8, 2022
@SWvheerden SWvheerden deleted the sw_fix_signatures branch December 8, 2022 10:17
@AaronFeickert AaronFeickert mentioned this pull request Dec 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeantonio21 jorgeantonio21 jorgeantonio21 left review comments

@stringhandler stringhandler stringhandler approved these changes

Assignees
No one assigned
Labels
W-consensus_breaking Warn - A change requiring a hard fork to be activated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SWvheerden @stringhandler @jorgeantonio21