fix: fix panic when no public addresses #5367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
the
P-acks_required
SWvheerden
reviewed
May 8, 2023
ghpbot-tari-project
added
the
P-reviews_required
SWvheerden
approved these changes
May 10, 2023
ghpbot-tari-project
removed
the
P-reviews_required
stringhandler
merged commit 49be2a2
into
tari-project:development
10 of 11 checks passed
SWvheerden
added a commit
that referenced
this pull request
May 29, 2023
## [0.50.0-pre.2](v0.50.0-pre.1...v0.50.0-pre.2) (2023-05-29) ### ⚠ BREAKING CHANGES * add optional range proof types (5372) ### Features * add metadata signature check ([5411](#5411)) ([9c2bf41](9c2bf41)) * add optional range proof types ([5372](#5372)) ([f24784f](f24784f)) * added burn feature to the console wallet ([5322](#5322)) ([45685b9](45685b9)) * improved base node monitoring ([5390](#5390)) ([c704890](c704890)) ### Bug Fixes * **comms:** only set final forward address if configured to port 0 ([5406](#5406)) ([ff7fb6d](ff7fb6d)) * deeplink to rfc spec ([5342](#5342)) ([806d3b8](806d3b8)) * don't use in memory datastores for chat client dht in integration tests ([#5399](#5399)) ([cbdca6f](cbdca6f)) * fix panic when no public addresses ([5367](#5367)) ([49be2a2](49be2a2)) * loop on mismatched passphrase entry ([5396](#5396)) ([ed120b2](ed120b2)) * use domain separation for wallet message signing ([5400](#5400)) ([7d71f8b](7d71f8b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If there are no public addresses specified, there was a panic. This is solved by not starting a liveness service if there is no public address.
NOTE: I have changed the reference on tari-crypto to be the lowest version that it works with (i.e. 0.16, instead of 0.16.*). This is the best practice for libraries, according to Rust, and also helps with mismatches on the tari-dan repo.
Motivation and Context
When using TCP, a node might not have a public address, this may cause a panic with the current code. AFAIK a comms node (base node, wallet, dan indexer) can still work without a public address, but it can only initiate outbound connections.
How Has This Been Tested?
existing tests
What process can a PR reviewer use to test or verify this change?
TODO: I'm busy checking this on the DAN indexer, which has no public address during testing
Breaking Changes