Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: up the timeout for comms #5758

Merged
merged 1 commit into from Sep 12, 2023
Merged

feat: up the timeout for comms #5758

merged 1 commit into from Sep 12, 2023

Conversation

SWvheerden
Copy link
Collaborator

Description

increase timeouts

Motivation and Context

We recently decreased timeouts across the communications. This increases it again somewhat after it was observed that the newer timeouts maybe too quick for slow tor connections

@github-actions
Copy link

Test Results (CI)

1 200 tests   1 200 ✔️  11m 27s ⏱️
     38 suites         0 💤
       1 files           0 ❌

Results for commit 256e428.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Sep 11, 2023
@github-actions
Copy link

Test Results (Integration tests)

27 tests  +27   27 ✔️ +27   14m 6s ⏱️ + 14m 6s
11 suites +11     0 💤 ±  0 
  2 files   +  2     0 ❌ ±  0 

Results for commit 256e428. ± Comparison against base commit 45c20a3.

sdbondi
sdbondi approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should set these defaults based on the selected transport. But otherwise happy for this to go in.

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Sep 12, 2023
@SWvheerden SWvheerden merged commit 1054868 into tari-project:development Sep 12, 2023
14 checks passed
@SWvheerden SWvheerden deleted the sw_up_timeout branch September 12, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdbondi sdbondi sdbondi approved these changes

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SWvheerden @sdbondi @ghpbot-tari-project