feat: prevent possible division by zero in difficulty calculation #5828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevented division by zero panic
ghpbot-tari-project
added
P-acks_required
AaronFeickert
approved these changes
Oct 2, 2023
ghpbot-tari-project
removed
the
P-reviews_required
|
ACK |
ghpbot-tari-project
removed
the
P-acks_required
SWvheerden
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevented possible division by zero panic in
fn u256_scalar_to_difficulty(scalar: U256) -> Result<Difficulty, DifficultyError>Motivation and Context
Code should not be able to panic.
How Has This Been Tested?
Unit test added
What process can a PR reviewer use to test or verify this change?
Code walkthrough
Breaking Changes