refactor(proto)!: remove proto bytes for std bytes #5835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianp
force-pushed
the
refactor-proto-types-bytes
branch
2 times, most recently
from
c7f559a
to
43940a1
Compare
sdbondi
reviewed
Oct 10, 2023
ghpbot-tari-project
added
P-acks_required
brianp
force-pushed
the
refactor-proto-types-bytes
branch
from
43940a1
to
1482178
Compare
SWvheerden
approved these changes
Oct 11, 2023
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will remove the google proto bytes wrapper in favour of using a standard vec.
Motivation and Context
Use standard rust types, instead of library specific types.
Related to #5833
How Has This Been Tested?
CI
What process can a PR reviewer use to test or verify this change?
Previously used test values included
None,Some(vec![])andSome(FixedHash::zero()). This PR removes the option wrappers and as a result the previousSome(vec![])values will bevec![]and considered the equivalent toNone.Breaking Changes
Messages between new and old nodes are likely to break.