Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add lock height and kernel features checks on default transactions #5836

Conversation

brianp
Copy link
Contributor

@brianp brianp commented Oct 10, 2023

Description

It helps to ensure the wallet doesn't end up with non-spendable inputs preventing the ability to submit transactions.

Motivation and Context

Closes: #5796

How Has This Been Tested?

What process can a PR reviewer use to test or verify this change?

Double-check the spelling.

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

Helps to ensure the wallet doesn't end up with non spendable inputs
preventing the ability to spend transactions.
@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Oct 10, 2023
@github-actions
Copy link

Test Results (CI)

1 219 tests   1 219 ✔️  10m 16s ⏱️
     39 suites         0 💤
       1 files           0

Results for commit 30c1565.

@github-actions
Copy link

Test Results (Integration tests)

33 tests  +33   33 ✔️ +33   13m 6s ⏱️ + 13m 6s
11 suites +11     0 💤 ±  0 
  2 files   +  2     0 ±  0 

Results for commit 30c1565. ± Comparison against base commit 38dc014.

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Oct 11, 2023
@SWvheerden SWvheerden merged commit 1f87226 into tari-project:development Oct 11, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wallet get_default_recipient_transaction should check kernel features of default transactions
3 participants