Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix erroneous warning message #5846

Merged
merged 2 commits into from Oct 19, 2023
Merged

fix: fix erroneous warning message #5846

merged 2 commits into from Oct 19, 2023

Conversation

hansieodendaal
Copy link
Contributor

Description

Fixed erroneous warning message about 'orphans_db' and 'orphan_header_accumulated_data_db' being out of sync - the difference was assumed instead of verified.

Motivation and Context

See above

How Has This Been Tested?

System-level test

What process can a PR reviewer use to test or verify this change?

Code review

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@hansieodendaal
Fix erroneous warning message
a249f7d 
Fixed erroneous warning message about 'orphans_db' and 'orphan_header_accumulated_data_db' being out of sync
stringhandler
stringhandler reviewed Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@stringhandler stringhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this solves the problem. Stylistically, this if state was already complicated and this adds another level to it. Can we maybe clean up the method to have fewer nested ifs?

@github-actions
Copy link

github-actions bot commented Oct 19, 2023 •
edited

Test Results (CI)

1 222 tests   1 222 ✔️  9m 36s ⏱️
     39 suites         0 💤
       1 files           0 ❌

Results for commit 2b0013b.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Oct 19, 2023
@github-actions
Copy link

github-actions bot commented Oct 19, 2023 •
edited

Test Results (Integration tests)

33 tests  +33   33 ✔️ +33   13m 17s ⏱️ + 13m 17s
11 suites +11     0 💤 ±  0 
  2 files   +  2     0 ❌ ±  0 

Results for commit 2b0013b. ± Comparison against base commit eb40fc4.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Oct 19, 2023
@stringhandler stringhandler merged commit 8afcd8b into tari-project:development Oct 19, 2023
14 checks passed
@hansieodendaal hansieodendaal deleted the ho_fix_warn_msg branch October 19, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stringhandler stringhandler stringhandler approved these changes

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hansieodendaal @stringhandler @ghpbot-tari-project