Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: print warning for wallets in direct send only #5883

Merged

Conversation

SWvheerden
Copy link
Collaborator

Description

Prints out a warning for wallets set to use direct send only

Motivation and Context

See: #5861

How Has This Been Tested?

Manual

Fixes: #5861

@github-actions
Copy link

github-actions bot commented Oct 27, 2023

Test Results (CI)

1 243 tests   1 243 ✔️  9m 21s ⏱️
     39 suites         0 💤
       1 files           0

Results for commit bc283c1.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Oct 27, 2023
@github-actions
Copy link

github-actions bot commented Oct 27, 2023

Test Results (Integration tests)

  2 files  +  2  11 suites  +11   13m 21s ⏱️ + 13m 21s
34 tests +34  33 ✔️ +33  0 💤 ±0  1 +1 
35 runs  +35  34 ✔️ +34  0 💤 ±0  1 +1 

For more details on these failures, see this check.

Results for commit bc283c1. ± Comparison against base commit 5c2781e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Nov 1, 2023
@SWvheerden SWvheerden merged commit 6d8686d into tari-project:development Nov 1, 2023
13 of 14 checks passed
@SWvheerden SWvheerden deleted the sw_warning_directsend branch November 1, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set warning if wallet is set to only send via direct send
3 participants