feat: allow multiple initial sync peers #5890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files + 2 11 suites +11 16m 52s ⏱️ + 16m 52s For more details on these failures, see this check. Results for commit 086e7df. ± Comparison against base commit 4ca664e. ♻️ This comment has been updated with latest results. |
SWvheerden
commented
Nov 1, 2023
base_layer/core/src/base_node/state_machine_service/states/listening.rs
Outdated
Show resolved
Hide resolved
SWvheerden
commented
Nov 1, 2023
base_layer/core/src/base_node/state_machine_service/states/listening.rs
Outdated
Show resolved
Hide resolved
hansieodendaal
approved these changes
Nov 1, 2023
ghpbot-tari-project
removed
the
P-reviews_required
SWvheerden
pushed a commit
that referenced
this pull request
Nov 1, 2023
Description --- Updates a latency test to be deterministic and exercise more cases. Motivation and Context --- A recent update in #5890 adds a test for sorting peers by latency. Its test is randomized and may not fully exercise all the desired cases. This PR makes a simple change that updates the test to be deterministic. How Has This Been Tested? --- It's a test, which passes! What process can a PR reviewer use to test or verify this change? --- Confirm that the test does what it says it does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow syncing from multiple peers initially
Motivation and Context
See issue: #5852
This allows a node to wait until it gets 5 ChainMetaData during initial sync until it goes to header sync.
How Has This Been Tested?
Unit tests
Fixes: #5852