Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adaptable min difficulty check #5896

Merged
merged 3 commits into from Nov 7, 2023
Merged

feat: adaptable min difficulty check #5896

merged 3 commits into from Nov 7, 2023

Conversation

SWvheerden
Copy link
Collaborator

Description

This includes an adaptable min difficulty check for incoming blocks.

Motivation and Context

See issue: #5620 for the reasoning behind why this needs to include an adaptable min difficulty check.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023 •
edited

Test Results (CI)

1 253 tests   1 253 ✔️  15m 5s ⏱️
     39 suites         0 💤
       1 files           0 ❌

Results for commit b66d588.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Nov 1, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023 •
edited

Test Results (Integration tests)

31 tests   31 ✔️  16m 2s ⏱️
11 suites    0 💤
  2 files      0 ❌

Results for commit b66d588.

♻️ This comment has been updated with latest results.

@SWvheerden SWvheerden mentioned this pull request Nov 2, 2023
Closed
brianp
brianp requested changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for the checked_div_u64 functions. I probably need a clarification on the way we're using the min difficulty we're calculating because it looks like it could be possible to keep the value at 1.

base_layer/core/src/proof_of_work/difficulty.rs Outdated Show resolved Hide resolved
brianp
brianp approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, utAck

@SWvheerden SWvheerden merged commit 76f323c into tari-project:development Nov 7, 2023
14 checks passed
@SWvheerden SWvheerden deleted the sw_min_difficulty_check branch November 7, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianp brianp brianp approved these changes

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SWvheerden @brianp @ghpbot-tari-project