Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create min dust fee setting #5947

Merged
merged 2 commits into from Nov 14, 2023
Merged

feat: create min dust fee setting #5947

merged 2 commits into from Nov 14, 2023

Conversation

SWvheerden
Copy link
Collaborator

Description

Create a setting to ignore dust below a certain value/

Motivation and Context

See #5807

Fixes: #5807
Fixes: #4501

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2023 •
edited

Test Results (CI)

1 258 tests   1 258 ✔️  16m 39s ⏱️
     39 suites         0 💤
       1 files           0 ❌

Results for commit 030a8f3.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Nov 13, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2023 •
edited

Test Results (Integration tests)

31 tests   31 ✔️  15m 26s ⏱️
11 suites    0 💤
  2 files      0 ❌

Results for commit 030a8f3.

♻️ This comment has been updated with latest results.

@SWvheerden SWvheerden mentioned this pull request Nov 14, 2023
Merged
brianp
brianp reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

Mostly looks good. Two comments.

base_layer/wallet/src/output_manager_service/input_selection.rs Show resolved Hide resolved
common/config/presets/d_console_wallet.toml Outdated Show resolved Hide resolved
SWvheerden and others added 2 commits November 14, 2023 15:58
@SWvheerden
create min dust fee setting
653859f
@SWvheerden @brianp
Update common/config/presets/d_console_wallet.toml
030a8f3 
Co-authored-by: Brian Pearce <brianp@users.noreply.github.com>
@SWvheerden SWvheerden merged commit 8f5466c into tari-project:development Nov 14, 2023
14 checks passed
@SWvheerden SWvheerden deleted the sw_sut_fee branch November 15, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianp brianp brianp left review comments

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default output selection criteria can be abused to increase the sender's fee Add setting to ignore dust
3 participants
@SWvheerden @brianp @ghpbot-tari-project