feat!: move kernel MMR position to u64
#5956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
force-pushed
the
kernel-mmr-position
branch
from
a5acd35
to
f463bdd
Compare
AaronFeickert
changed the title
u64u64
ghpbot-tari-project
added
P-acks_required
SWvheerden
approved these changes
Nov 16, 2023
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switches the handling of kernel MMR positions from
u32tou64.Closes #5924.
Motivation and Context
Internally, MMR positions are handled as either
usizeoru64. However, they are eventually parsed and handled asu32for storage. While it doesn't address the internalusizehandling, it switches storage operations to beu64.How Has This Been Tested?
Existing tests pass.
What process can a PR reviewer use to test or verify this change?
Assert that the logic, especially around LMDB operations, is correct.
BREAKING CHANGE: Modifies the handling of kernel MMR data in LMDB.