fix: update ToRistrettoPoint handling
#5973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
force-pushed
the
opcode-point
branch
from
eb68471
to
8ded069
Compare
AaronFeickert
changed the title
ToRistrettoPoint documentation and testToRistrettoPoint handling
ghpbot-tari-project
added
P-acks_required
AaronFeickert
force-pushed
the
opcode-point
branch
from
8ded069
to
b7caf2b
Compare
AaronFeickert
changed the title
ToRistrettoPoint handlingToRistrettoPoint handling
SWvheerden
approved these changes
Nov 21, 2023
ghpbot-tari-project
removed
the
P-reviews_required
sdbondi
pushed a commit
to sdbondi/tari
that referenced
this pull request
Nov 27, 2023
Description --- Updates the handling of the `ToRistrettoPoint` opcode. Closes tari-project#5818. Motivation and Context --- The `ToRistrettoPoint` opcode now requires that stack input be the canonical encoding of a Ristretto secret key. This PR updates the opcode documentation and adds a test for proper handling of invalid encoding. It also corrects the error returned on invalid stack input. There is a [separate PR](tari-project/rfcs#113) that updates the RFC documentation. How Has This Been Tested? --- Existing tests pass. A modified test passes. What process can a PR reviewer use to test or verify this change? --- Check that the updated documentation reflects the opcode handling. Check that the modified test correctly detects invalid input. Check that the error returned on invalid input is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the handling of the
ToRistrettoPointopcode.Closes #5818.
Motivation and Context
The
ToRistrettoPointopcode now requires that stack input be the canonical encoding of a Ristretto secret key. This PR updates the opcode documentation and adds a test for proper handling of invalid encoding. It also corrects the error returned on invalid stack input.There is a separate PR that updates the RFC documentation.
How Has This Been Tested?
Existing tests pass. A modified test passes.
What process can a PR reviewer use to test or verify this change?
Check that the updated documentation reflects the opcode handling. Check that the modified test correctly detects invalid input. Check that the error returned on invalid input is correct.