Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make base node support 1 click mining #6019

Merged
merged 2 commits into from Dec 8, 2023

Conversation

SWvheerden
Copy link
Collaborator

@SWvheerden SWvheerden commented Dec 6, 2023

Description

On startup make the basenode ask you if you want to run mining or not.
Add a flag --enable-mining
Fix base node flag --enable-grpc

Motivation and Context

This will make it easier to mine from a 1-click perspective where a new miner does not need to edit confiles in order to mine

How Has This Been Tested?

manual

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Dec 6, 2023
Copy link

github-actions bot commented Dec 6, 2023

Test Results (CI)

1 262 tests   1 262 ✔️  17m 34s ⏱️
     39 suites         0 💤
       1 files           0

Results for commit b09803b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 6, 2023

Test Results (Integration tests)

  2 files  12 suites   1h 38m 43s ⏱️
32 tests 26 ✔️ 0 💤   6
43 runs  27 ✔️ 0 💤 16

For more details on these failures, see this check.

Results for commit 8400e0b.

♻️ This comment has been updated with latest results.

1 click bn ready miner
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended, nice.

Some comments below.

@SWvheerden SWvheerden merged commit d377269 into tari-project:development Dec 8, 2023
12 of 13 checks passed
@SWvheerden SWvheerden deleted the sw_one_clock_bn branch December 8, 2023 13:10
Comment on lines +64 to +105
########################################################################################################################
# #
# Base Node Configuration Options (BaseNodeConfig) #
# #
########################################################################################################################

# If you are not running a Minotari Base node, you can simply leave everything in this section commented out. Base nodes
# help maintain the security of the Minotari token and are the surest way to preserve your privacy and be 100% sure that
# no-one is cheating you out of your money.

[dibbler.base_node]
# A path to the file that stores your node identity and secret key (default = "config/base_node_id.json")
identity_file = "config/base_node_id_dibbler.json"

[igor.base_node]
# A path to the file that stores your node identity and secret key (default = "config/base_node_id.json")
identity_file = "config/base_node_id_igor.json"

[esmeralda.base_node]
# A path to the file that stores your node identity and secret key (default = "config/base_node_id.json")
identity_file = "config/base_node_id_esmeralda.json"

[stagenet.base_node]
# A path to the file that stores your node identity and secret key (default = "config/base_node_id.json")
identity_file = "config/base_node_id_stagenet.json"

[nextnet.base_node]
# A path to the file that stores your node identity and secret key (default = "config/base_node_id.json")
identity_file = "config/base_node_id_nextnet.json"

[base_node]
# Set to false to disable the base node GRPC server (default = true)
#grpc_enabled = true

# The socket to expose for the gRPC base node server (default = "/ip4/127.0.0.1/tcp/18142")
#grpc_address = "/ip4/127.0.0.1/tcp/18142"

# gRPC authentication method (default = "none")
#grpc_authentication = { username = "admin", password = "xxxx" }

# Use gRPC over TLS (default = false)
#grpc_tls_enabled = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SWvheerden this is now duplicated in b_peer_seeds.toml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #6029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants