Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make all apps non interactive #6049

Merged
merged 1 commit into from Dec 14, 2023
Merged

feat: make all apps non interactive #6049

merged 1 commit into from Dec 14, 2023

Conversation

SWvheerden
Copy link
Collaborator

Description

make all applications hnour the non-interactive flag
Make base node non mining config default, and disable grpc server

How Has This Been Tested?

manual

@github-actions GitHub Actions
Copy link

Test Results (CI)

1 264 tests   1 264 ✔️  11m 56s ⏱️
     39 suites         0 💤
       1 files           0 ❌

Results for commit 6d45685.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Dec 14, 2023
@github-actions GitHub Actions
Copy link

Test Results (Integration tests)

29 tests   29 ✔️  11m 57s ⏱️
11 suites    0 💤
  2 files      0 ❌

Results for commit 6d45685.

hansieodendaal
hansieodendaal approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

The comments are probably just nits

applications/minotari_merge_mining_proxy/src/cli.rs Show resolved Hide resolved
applications/minotari_miner/src/cli.rs Show resolved Hide resolved
@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Dec 14, 2023
@SWvheerden SWvheerden merged commit bafd7e7 into tari-project:development Dec 14, 2023
13 of 14 checks passed
@SWvheerden SWvheerden deleted the sw_non-interactive branch January 26, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansieodendaal hansieodendaal hansieodendaal approved these changes

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SWvheerden @hansieodendaal @ghpbot-tari-project