fix: make monero extra data less strict #6117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWvheerden
changed the title
ghpbot-tari-project
added
P-acks_required
stringhandler
previously approved these changes
Feb 2, 2024
| @@ -105,8 +105,11 @@ pub fn verify_header( | |||
| ) -> Result<MoneroPowData, MergeMineError> { | |||
| let monero_data = MoneroPowData::from_header(header, consensus)?; | |||
| let expected_merge_mining_hash = header.merge_mining_hash(); | |||
| let extra_field = ExtraField::try_parse(&monero_data.coinbase_tx_extra) | |||
| .map_err(|_| MergeMineError::DeserializeError("Invalid extra field".to_string()))?; | |||
| let extra_field = ExtraField::try_parse(&monero_data.coinbase_tx_extra); | |||
There was a problem hiding this comment.
Is there no other data about the error here?
Maybe create an issue to add more data about what went wrong
ghpbot-tari-project
removed
P-reviews_required
Test Results (CI)1 269 tests 1 269 ✅ 11m 26s ⏱️ Results for commit c67d4d0. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It reverts a change to make the extra field acceptance less strict.
Motivation and Context
Tari only cares about the Merge mining field and not the rest. As long as that deserializes correct we are secure.