Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change CLI get_block to search orphans #6153

Merged
merged 1 commit into from Feb 20, 2024

Conversation

SWvheerden
Copy link
Collaborator

Description

Allows the get_block command, to search for the block in the orphan db as well.

Motivation and Context

From the CI we need to be able to see how reorged blocks look.

Copy link

Test Results (CI)

1 270 tests   1 270 ✅  12m 39s ⏱️
   39 suites      0 💤
    1 files        0 ❌

Results for commit bdec9c3.

@ghpbot-tari-project ghpbot-tari-project added P-reviews_required Process - Requires a review from a lead maintainer to be merged P-acks_required Process - Requires more ACKs or utACKs labels Feb 16, 2024
Copy link

Test Results (Integration tests)

 2 files  11 suites   14m 10s ⏱️
29 tests 28 ✅ 0 💤 1 ❌
30 runs  29 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit bdec9c3.

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Note: Pity we could not re-use the code from NodeCommsRequest::GetBlockFromAllChains(hash) easily

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Feb 20, 2024
@SWvheerden SWvheerden merged commit ae1e379 into tari-project:development Feb 20, 2024
12 of 14 checks passed
@SWvheerden SWvheerden deleted the sw_search_oprhans branch February 20, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants