feat: limit transaction size #6154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 117 suites 36m 52s ⏱️ Results for commit 0b9197e. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files + 2 11 suites +11 26m 40s ⏱️ + 26m 40s For more details on these failures, see this check. Results for commit 0b9197e. ± Comparison against base commit 97fc7b3. ♻️ This comment has been updated with latest results. |
hansieodendaal
force-pushed
the
ho_limit_transaction_size
branch
2 times, most recently
from
287f722
to
460c677
Compare
hansieodendaal
force-pushed
the
ho_limit_transaction_size
branch
3 times, most recently
from
7112d23
to
227cdcf
Compare
SWvheerden
previously approved these changes
Feb 26, 2024
base_layer/wallet/src/transaction_service/protocols/transaction_send_protocol.rs
Outdated
Show resolved
Hide resolved
ghpbot-tari-project
removed
the
P-reviews_required
Added checks to ensure that transactions to self or that are negotiated between parties do not exceed the RPC frame size limit.
hansieodendaal
force-pushed
the
ho_limit_transaction_size
branch
from
8b2403b
to
0b9197e
Compare
ghpbot-tari-project
added
the
P-reviews_required
SWvheerden
approved these changes
Mar 1, 2024
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added checks to ensure that transactions negotiated between parties, transactions to self and imported transactions do not exceed the RPC frame size limit when the transaction is broadcast to the base node. This can easily happen when lots of dust inputs are collected to be spent. If a too-large transaction is detected in any of the transaction service protocols it will be cancelled so that the user can try to create a new transaction with different parameters, for example, to reduce the recipient amount.
Edit:
spend_dusttests to speed it up even more as suggested by @SWvheerdenMotivation and Context
See #6108
How Has This Been Tested?
Added unit tests:
test_spend_dust_to_self_in_oversized_transactiontest_spend_dust_to_other_in_oversized_transactiontest_spend_dust_happy_pathWhat process can a PR reviewer use to test or verify this change?
Code walk-through
Review unit tests
Breaking Changes