feat: mining ffi add coinbase add #6183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
the
CR-insufficient_context
Test Results (Integration tests)12 tests 12 ✅ 1m 7s ⏱️ For more details on these parsing errors, see this check. Results for commit e4d26f0. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (CI) 3 files 120 suites 43m 20s ⏱️ Results for commit e4d26f0. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
removed
the
P-reviews_required
ghpbot-tari-project
added
the
P-reviews_required
|
Nope fees are not missing, you need to include it in the value you want the coinbase to be |
| /// | ||
| /// ## Arguments | ||
| /// `block_template_bytes` - The block template as bytes, serialized with borsh.io | ||
| /// `value` - The value of the coinbase |
There was a problem hiding this comment.
If this includes the fee it should be like reward_and_fee or something and the comment should explain it
SWvheerden
force-pushed
the
sw_mining_ffi
branch
from
2f6dbe6
to
f57e8c1
Compare
SWvheerden
force-pushed
the
sw_mining_ffi
branch
from
75d46ba
to
752db4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add functionality to add coinbase