fix: downgrade crossterm for windows compatibility #6204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent updates `crossterm` to the latest version, `0.27.0`, from version `0.25.0`. The behaviour of keyboard events on Windows changed from version `0.26.0` upwards, making the use of the console wallet and to a lesser degree the base node in Windows Console unusable as multiple keystrokes events are generated for each keystroke. This PR did not seek to find a solution for upgrading to the latest version of `crossterm`, but merely to revert the change.
|
Crossterm was updated for a security problem: |
ghpbot-tari-project
added
P-acks_required
Test Results (CI) 3 files 120 suites 37m 23s ⏱️ Results for commit 95d6f4f. ♻️ This comment has been updated with latest results. |
Test Results (Integration tests)29 tests 29 ✅ 11m 38s ⏱️ Results for commit 95d6f4f. ♻️ This comment has been updated with latest results. |
SWvheerden
approved these changes
Mar 12, 2024
ghpbot-tari-project
removed
the
P-reviews_required
SWvheerden
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A recent PR updated
crosstermto the latest version,0.27.0, from version0.25.0. The behaviour of keyboard events on Windows changed from version0.26.0upwards, making the use of the console wallet and to a lesser degree the base node in Windows Console unusable as multiple keystrokes events are generated for each keystroke.This PR did not seek to find a solution for upgrading to the latest version of
crossterm, but merely to revert the change.Motivation and Context
See above.
How Has This Been Tested?
System-level testing
What process can a PR reviewer use to test or verify this change?
Review code changes
System-level testing
Breaking Changes