Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: base node write tor address #6210

Merged
merged 2 commits into from Mar 20, 2024

Conversation

SWvheerden
Copy link
Collaborator

Description

Base will now write tor address in the identity file

Motivation and Context

The base node needs to contain the tor address.

How Has This Been Tested?

manual

Copy link

github-actions bot commented Mar 13, 2024

Test Results (CI)

1 265 tests   1 262 ✅  27m 19s ⏱️
   40 suites      0 💤
    1 files        3 ❌

For more details on these failures, see this check.

Results for commit 7748061.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Mar 13, 2024
Copy link

github-actions bot commented Mar 13, 2024

Test Results (Integration tests)

 2 files  11 suites   21m 41s ⏱️
32 tests 29 ✅ 0 💤 3 ❌
36 runs  32 ✅ 0 💤 4 ❌

For more details on these failures, see this check.

Results for commit 7748061.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Mar 14, 2024
@SWvheerden SWvheerden merged commit 019a909 into tari-project:development Mar 20, 2024
13 of 16 checks passed
@SWvheerden SWvheerden deleted the sw_fix_address branch April 15, 2024 09:13
SWvheerden added a commit to SWvheerden/tari that referenced this pull request Apr 15, 2024
Description
---
Base will now write tor address in the identity file

Motivation and Context
---
The base node needs to contain the tor address. 

How Has This Been Tested?
---
manual
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants