Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change mmproxy to select new monerod on error #6321

Merged
merged 1 commit into from
May 7, 2024

Conversation

SWvheerden
Copy link
Collaborator

Description

Make sure the MMProxy does select a new node on error

Motivation and Context

Its possible for the monerod to error out on SSL, but not send back and error. The MMProxy then gets this error and keeps retrying the node:

ERROR Method "getblocktemplate" failed handling request: MonerodRequestFailed(reqwest::Error { kind: Request, url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("xmr.grub.net")), port: Some(18089), path: "/json_rpc", query: None, fragment: None }, source: hyper::Error(Connect, Ssl(Error { code: ErrorCode(1), cause: Some(Ssl(ErrorStack([Error { code: 167772294, library: "SSL routines", function: "tls_post_process_server_certificate", reason: "certificate verify failed", file: "ssl/statem/statem_clnt.c", line: 1889 }]))) }, X509VerifyResult { code: 18, error: "self-signed certificate" })) })

On Any error the MMProxy will now select a new monerod from the list it has.

Copy link

github-actions bot commented May 6, 2024

Test Results (CI)

    3 files    120 suites   39m 1s ⏱️
1 277 tests 1 277 ✅ 0 💤 0 ❌
3 823 runs  3 823 ✅ 0 💤 0 ❌

Results for commit 2896351.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels May 6, 2024
Copy link

github-actions bot commented May 6, 2024

Test Results (Integration tests)

 2 files  11 suites   22m 20s ⏱️
33 tests 32 ✅ 0 💤 1 ❌
34 runs  33 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 2896351.

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should do it.

utACK

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label May 7, 2024
@SWvheerden SWvheerden merged commit 2a9250b into tari-project:development May 7, 2024
14 of 16 checks passed
@SWvheerden SWvheerden deleted the sw_mm_porxy_error branch May 7, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants