Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix base node console display #6341

Conversation

hansieodendaal
Copy link
Contributor

Description

Fixed base node console display to show hdrs/s when syncing headers instead of blks/s

Motivation and Context

See above

How Has This Been Tested?

System-level testing

What process can a PR reviewer use to test or verify this change?

Code review

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

Fixed base node console display to show `hdrs/s` when syncing headers instead of `blks/s`
@hansieodendaal hansieodendaal requested a review from a team as a code owner May 16, 2024 11:28
Copy link

Test Results (CI)

    3 files    120 suites   38m 21s ⏱️
1 279 tests 1 279 ✅ 0 💤 0 ❌
3 829 runs  3 829 ✅ 0 💤 0 ❌

Results for commit 62eb2ac.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels May 16, 2024
Copy link

Test Results (Integration tests)

 2 files  11 suites   32m 15s ⏱️
33 tests 32 ✅ 0 💤 1 ❌
35 runs  33 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 62eb2ac.

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label May 16, 2024
@SWvheerden SWvheerden merged commit df0d801 into tari-project:development May 16, 2024
14 of 16 checks passed
@hansieodendaal hansieodendaal deleted the ho_fix_base_node_console_display branch May 17, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants