Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust block sync timeouts #6342

Merged

Conversation

hansieodendaal
Copy link
Contributor

Description

Adjusted block sync timeouts to enable block sync over tor when we have many full blocks. Previous values were unrealistic and unfeasible. This PR provides feasible default values for full blocks sync over tor for a fresh base node.

Motivation and Context

A recent stress test on esemeralda provided a blockchain with many full blocks. Performing a fresh base node block sync over tor in a controlled environment proved impossible due to inherent network latencies. Although there may be a fix to improve the tor latencies with full blocks sync, it is not yet available.

2024-05-14 17:16:00.091735600 [c::bn::block_sync] TRACE [block sync timings] 1.1 #1501 Latency in 134.48s
2024-05-14 17:18:56.454123100 [c::bn::block_sync] TRACE [block sync timings] 1.1 #1502 Latency in 173.69s
2024-05-14 17:21:15.535060700 [c::bn::block_sync] TRACE [block sync timings] 1.1 #1503 Latency in 136.89s
2024-05-14 17:24:15.852873000 [c::bn::block_sync] TRACE [block sync timings] 1.1 #1504 Latency in 178.57s
2024-05-14 17:26:53.273228300 [c::bn::block_sync] TRACE [block sync timings] 1.1 #1505 Latency in 155.62s

How Has This Been Tested?

Many system-level tests.

What process can a PR reviewer use to test or verify this change?

Code review and system-level tests.

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

Adjusted block sync timeouts to enable block sync over tor when we have many full blocks. Previous
values were unrealistic and unfeasible.
@hansieodendaal hansieodendaal requested a review from a team as a code owner May 16, 2024 12:13
Copy link

Test Results (CI)

    3 files    120 suites   43m 57s ⏱️
1 279 tests 1 279 ✅ 0 💤 0 ❌
3 829 runs  3 829 ✅ 0 💤 0 ❌

Results for commit 25d4b93.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels May 16, 2024
Copy link

Test Results (Integration tests)

 2 files  11 suites   25m 3s ⏱️
33 tests 30 ✅ 0 💤 3 ❌
37 runs  32 ✅ 0 💤 5 ❌

For more details on these failures, see this check.

Results for commit 25d4b93.

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label May 16, 2024
@SWvheerden SWvheerden merged commit 16ca4b5 into tari-project:development May 16, 2024
14 of 16 checks passed
@hansieodendaal hansieodendaal deleted the ho_block_sync_timeouts branch May 17, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants