feat: improve initial connection times #6343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved initial connection times for nodes when previous connections to peers failed, as well as when a node loses all connectivity.
Test Results (Integration tests)33 tests 33 ✅ 13m 16s ⏱️ Results for commit e641428. |
ghpbot-tari-project
added
P-acks_required
Test Results (CI) 3 files 120 suites 37m 8s ⏱️ Results for commit e641428. |
SWvheerden
approved these changes
May 16, 2024
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved initial connection times from a dht perspective for nodes at startup when all previous connections to peers failed, as well as when a node lost all connectivity. With this PR a node will attempt to connect to peers with previously failed attempts under such circumstances, improving general connectivity. Nodes will refresh their dht neighbour list without discriminating against those peers so that all nodes can be tried again.
Motivation and Context
When a node starts up or loses all connectivity and all known peers have had a failed connection, the node will wait for a 24-hour cooldown period before the same nodes are contacted again.
How Has This Been Tested?
System-level testing.
What process can a PR reviewer use to test or verify this change?
Code review.
Breaking Changes