Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: atomic swap #6360

Merged
merged 1 commit into from
May 30, 2024
Merged

fix: atomic swap #6360

merged 1 commit into from
May 30, 2024

Conversation

SWvheerden
Copy link
Collaborator

Description

Fixes atomic swap

Motivation and Context

Atomic swap should use the existing on chain rangeproof and not generate a new one.

@SWvheerden SWvheerden requested a review from a team as a code owner May 28, 2024 19:02
@github-actions GitHub Actions
Copy link

Test Results (CI)

    3 files    120 suites   36m 32s ⏱️
1 275 tests 1 275 ✅ 0 💤 0 ❌
3 817 runs  3 817 ✅ 0 💤 0 ❌

Results for commit 7757dba.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels May 28, 2024
@github-actions GitHub Actions
Copy link

Test Results (Integration tests)

 2 files  11 suites   23m 4s ⏱️
34 tests 32 ✅ 0 💤 2 ❌
36 runs  34 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 7757dba.

hansieodendaal
hansieodendaal approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label May 30, 2024
@SWvheerden SWvheerden merged commit 01f93ab into tari-project:development May 30, 2024
14 of 16 checks passed
@SWvheerden SWvheerden deleted the sw_fix_atomicswap branch May 30, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansieodendaal hansieodendaal hansieodendaal approved these changes

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SWvheerden @hansieodendaal @ghpbot-tari-project