Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup and Restore: Restore Wallet screen: Encrypted and Unencrypted backup flow #474

Closed
Tas4tari opened this issue Jul 17, 2020 · 6 comments · Fixed by #510
Closed

Backup and Restore: Restore Wallet screen: Encrypted and Unencrypted backup flow #474

Tas4tari opened this issue Jul 17, 2020 · 6 comments · Fixed by #510
Labels
enhancement New feature or request

Comments

@Tas4tari
Copy link

Tas4tari commented Jul 17, 2020

Description:
Currently when the user selects "Restore an existing wallet", the screen displayed is the "Enter a password" screen with the Restore Wallet button enabled.
The button here is enabled so that if a user did not encrypt their back up, they could select the button to Restore their existing unencrypted back up, however this can be misleading to users.

Acceptance criteria

@nyarian Please let me know if this is understandable

@Tas4tari Tas4tari added the enhancement New feature or request label Jul 17, 2020
@kukabi kukabi self-assigned this Jul 22, 2020
@kukabi
Copy link
Contributor

kukabi commented Jul 22, 2020

Tested the app, password entry screen does not get displayed for a non-encrypted password.

Password validation should not be done when entering password, it would give a clue about the password. Current behavior of enabling the button after a single character is entered seems to be good.

Moving the issue to UAT.

@Tas4tari
Copy link
Author

Tas4tari commented Jul 22, 2020

Test Scenarios:

  • User has an unencrypted wallet and does a Restore (No Enter password screen should display)
  • User has an encrypted wallet and does a restore:
    • Enter Password screen should display
    • Restore Wallet button should be disabled
    • When user enters a character into the Enter Password field, the Restore Wallet button should be automatically enabled

@Tas4tari
Copy link
Author

Tas4tari commented Jul 24, 2020

Tested unsuccessfully, the Restore Wallet button is still enabled: App version: v0.3.0.-jnLibs-0.16.0
https://drive.google.com/file/d/11_HgQKECvHRj3RhR0AIA_qySlHX9ZszW/view?usp=sharing

Need to be retested @Tas4tari

@Tas4tari
Copy link
Author

Tested unsuccessfully, the Restore Wallet button is still enabled: App version: v0.3.0.-jnLibs-0.16.0
https://drive.google.com/file/d/1cOJYAiOoDBMXmRh5ma7jixn1cQt2pJoQ/view?usp=sharing

kukabi added a commit that referenced this issue Jul 27, 2020
…TA button enabled/disabled fix #474. Settings and backup settings screen backup state display fix #509.
kukabi added a commit that referenced this issue Jul 27, 2020
…TA button enabled/disabled fix #474. Settings and backup settings screen backup state display fix #509.
kukabi added a commit that referenced this issue Jul 27, 2020
…TA button enabled/disabled fix #474. Settings and backup settings screen backup state display fix #509.
kukabi added a commit that referenced this issue Jul 27, 2020
…TA button enabled/disabled fix #474. Settings and backup settings screen backup state display fix #509.
@kukabi kukabi reopened this Jul 27, 2020
@Tas4tari
Copy link
Author

Tas4tari commented Jul 27, 2020

Tested successfully using the apk Regular release build on Huawei P30 Lite: https://drive.google.com/file/d/1wzk4x_GpOTeCp3xlJ1Erw7d-UvjsTQpB/view?usp=sharing

@Tas4tari
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants