Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opam: fix lower bounds #469

Merged
merged 2 commits into from
May 3, 2023
Merged

Conversation

emillon
Copy link
Collaborator

@emillon emillon commented May 3, 2023

We use Rresult.R.failwith_error_msg which has been added in 0.6.0.

We use `Rresult.R.failwith_error_msg` which has been added in 0.6.0.
2.7.1 includes a fix for cram tests
@Leonidas-from-XIV Leonidas-from-XIV self-requested a review May 3, 2023 14:30
Copy link
Member

@Leonidas-from-XIV Leonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix!

@Leonidas-from-XIV Leonidas-from-XIV added the no changelog Add this to your PRs to disable the changelog update check label May 3, 2023
@Leonidas-from-XIV Leonidas-from-XIV merged commit 17e1cae into tarides:main May 3, 2023
@emillon
Copy link
Collaborator Author

emillon commented May 4, 2023

This does not fix the lower bounds run, I was debugging the cram failure. I'll send a followup PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Add this to your PRs to disable the changelog update check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants