Allow resolving unprefixed refs #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test-case to ensure we don't introduce future regressions there? I'm not sure I understand this logic either. |
When using a pinned dependency the refs might not have a prefix (e.g. `HEAD` is a plain ref) thus they wouldn't have been found when attempting to resolve the refs. Closes tarides#326
Leonidas-from-XIV
force-pushed
the
resolve-unprefixed-refs
branch
2 times, most recently
from
d67a54b
to
1091af2
Compare
Leonidas-from-XIV
force-pushed
the
resolve-unprefixed-refs
branch
from
1091af2
to
0472846
Compare
Leonidas-from-XIV
requested review from
samoht
and removed request for
NathanReb
Leonidas-from-XIV
force-pushed
the
resolve-unprefixed-refs
branch
from
839cc57
to
e137fca
Compare
|
@samoht I've added a test. It's a bit ugly since it messes with the global OPAM state (by creating a pin called |
gridbugs
approved these changes
Nov 24, 2022
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Dec 21, 2022
CHANGES: ### Changed - Treat packages with no build commands as if they can be built with dune (tarides/opam-monorepo#355, @gridbugs) ### Fixed - Fix resolving refs of locally pinned repositories (tarides/opam-monorepo#326, tarides/opam-monorepo#332, @hannesm, @Leonidas-from-XIV) - Read the `compiler` flag from OPAM metadata thus classifying more packages correctly as base packages (tarides/opam-monorepo#328, @Leonidas-from-XIV) - Fix bug where dev repo urls ending with a "/" would result in `opam monorepo pull` placing package source code directly inside the duniverse directory instead of in a subdirectory of the duniverse directory (tarides/opam-monorepo#359, @gridbugs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a pinned dependency the refs might not have a prefix (e.g.
HEADis a plain ref) thus they wouldn't have been found when attempting to resolve the refs.Closes #326