Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where dev repo urls ending with a "/" would result in opam monorepo pull placing package source code directly inside the duniverse directory instead of in a subdirectory of the duniverse directory #359

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Fix bug where dev repo urls ending with a "/" would result in opam monorepo pull placing package source code directly inside the duniverse directory instead of in a subdirectory of the duniverse directory #359

merged 3 commits into from
Dec 6, 2022

Commits on Dec 2, 2022

  1. Fix handling of dev_repos ending with a "/" 

    Previously these would be given a dev repo name of "" in the lockfile.
This would result in `opam monorepo pull` checking out package source
code directly inside the "duniverse" directory instead of in a
subdirectory.

Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
    @gridbugs
    gridbugs committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    4d51702 View commit details
    Browse the repository at this point in the history

  2. Only pull packages to descendants of duniverse dir 

    Previously, certain adversarial dev repo names (e.g. "", "..") would
cause `opam monorepo pull` to create and delete files outside the
duniverse directory, or to place package source code directly inside the
duniverse directory instead of a subdirectory. This change adds a check
which prevents code being pulled into directories which are not
descendants of the duniverse directory.

Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
    @gridbugs
    gridbugs committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    2773ea9 View commit details
    Browse the repository at this point in the history

  3. Remove unused function String.drop_suffix 

    Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
    @gridbugs
    gridbugs committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    64b718f View commit details
    Browse the repository at this point in the history