Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize Github URLs before comparing #365

Merged
merged 6 commits into from
Jan 13, 2023
Merged

Normalize Github URLs before comparing #365

merged 6 commits into from
Jan 13, 2023

Commits on Jan 12, 2023

  1. Add tests with the expectation of how the values should look like

    @Leonidas-from-XIV
    Leonidas-from-XIV committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    a0c045d View commit details
    Browse the repository at this point in the history

  2. Use canonicalization when comparing URIs

    @Leonidas-from-XIV
    Leonidas-from-XIV committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    f465f85 View commit details
    Browse the repository at this point in the history

  3. Implement the unit tests

    @Leonidas-from-XIV
    Leonidas-from-XIV committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    4e7de16 View commit details
    Browse the repository at this point in the history

  4. Add entry to changelog

    @Leonidas-from-XIV
    Leonidas-from-XIV committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    529754c View commit details
    Browse the repository at this point in the history

  5. Wrap canonical URL in a module 

    This makes sure that the conversion is a one-way street and the
canonical URLs, whatever they might be will not be used for any other
purposes but `pp` and (more importantly) `equal`.
    @Leonidas-from-XIV
    Leonidas-from-XIV committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    9575e7e View commit details
    Browse the repository at this point in the history

  6. Normalize only on github.com URLs

    @Leonidas-from-XIV
    Leonidas-from-XIV committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    1672e81 View commit details
    Browse the repository at this point in the history