Fall Back to Entry id if Entry Links Do Not Exist #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmattio
reviewed
Nov 21, 2023
lib/post.ml
Outdated
| @@ -163,7 +163,7 @@ let post_of_atom ~(feed : Feed.t) (e : Syndic.Atom.entry) = | |||
| (List.find (fun l -> l.Syndic.Atom.rel = Syndic.Atom.Alternate) e.links) | |||
| .href | |||
| with Not_found -> ( | |||
| match e.links with l :: _ -> Some l.href | [] -> None) | |||
| match e.links with l :: _ -> Some l.href | [] -> Some e.id) | |||
There was a problem hiding this comment.
Should we check that id is a valid URL?
There was a problem hiding this comment.
https://www.ietf.org/rfc/rfc4287.txt
It seems that, even if the URI is valid, there's no guarantee that a resource can be fetched via HTTP (i.e. it's allowed for Atom feeds to declare resources that are not dereferencable).
4.2.6. The "atom:id" Element
The "atom:id" element conveys a permanent, universally unique
identifier for an entry or feed.
atomId = element atom:id {
atomCommonAttributes,
(atomUri)
}
Its content MUST be an IRI, as defined by [RFC3987]. Note that the
definition of "IRI" excludes relative references. Though the IRI
might use a dereferencable scheme, Atom Processors MUST NOT assume it
can be dereferenced.
There was a problem hiding this comment.
I added a check on the URI scheme, so that we only recognise this as a link if the scheme is "http" or "https".
sabine
force-pushed
the
fallback_to_id_if_no_links
branch
from
cb52385
to
572ae42
Compare
|
With these changes, the feed from ocaml/ocaml.org#1776 is consumed successfully. |
|
Thank you! |
tmattio
added a commit
to tmattio/opam-repository
that referenced
this pull request
Nov 21, 2023
CHANGES: - Fall back to entry id if entry links doesn't exist (tarides/river#11, @sabine)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is legal for an Atom feed to not have
links.In this case, it appears sensible to rely on the value provided by the
idtag.