Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when clicking the refresh icon (<i> element) it doesn't work correctly #87

Closed
devin0910 opened this issue Feb 7, 2014 · 2 comments
Closed

when clicking the refresh icon (<i> element) it doesn't work correctly #87

devin0910 opened this issue Feb 7, 2014 · 2 comments

Comments

@devin0910
Copy link

adding following codes to base.js #after line 24

var idName = event.target.id;
if (idName == "") {
var idName = $(event.target).parent("div").attr("id");
}
var item = idName.split("-").splice(-1)[0];
@commonquail
Copy link
Contributor

This would be treating the symptom, not the cause. Please see #86.

commonquail added a commit to commonquail/linux-dash that referenced this issue Feb 8, 2014
@commonquail
Fix tariqbuilds#86, tariqbuilds#87: broken refresh buttons.
910ea88 
Clicking the refresh icon would yield the wrong element ID. This moves
the refresh icon from a separate element to the button container, so the
icon is the button as opposed to being contained within it.
@tariqbuilds
Copy link
Owner

Addressed by #92 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@devin0910 @commonquail @tariqbuilds