Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refreshing issue #86

Closed
Charlese2 opened this issue Feb 7, 2014 · 1 comment
Closed

Refreshing issue #86

Charlese2 opened this issue Feb 7, 2014 · 1 comment

Comments

@Charlese2
Copy link

When clicking the the individual refresh buttons, if you click on the little refresh icon in the center of the refresh button it returns the "id" of the refresh icon instead of the button.
refresh1
Clicking on the outer edge returns the button's "id" like it is supposed to.
refresh2

@commonquail
Copy link
Contributor

I was actually aware of this when I changed the click handler but then forgot all about it before submitting. I was thinking there had to be a more correct way to manage icons -- the icon should be the button, it shouldn't be contained within it as is currently the case. There was a regression in 6e399df when the text was removed.
Don't change the JavaScript to work around this, change the HTML to eliminate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants