changed response type to be application/json per #10 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,5 +59,6 @@ | |||
| $final .= ']'; | |||
|
|
|||
| echo($final); | |||
| ?> | |||
There was a problem hiding this comment.
From a best-practices perspective the ?> tag is occasionally problematic and shouldn't be used unless strictly necessary (i.e. literal output follows it). It shouldn't cause a lot a issues in a project like this but this one line is an example of a case where the semantics are subtly changed because of the following two empty lines. Yes, those two empty lines probably shouldn't be there (they weren't doing anything in the original file), but the more robust solution is to simply not use ?>.
There was a problem hiding this comment.
@commonquail thanks for explaining this, it makes sense. I've just always used the closing tag ?> in my php development.
tariqbuilds
added a commit
that referenced
this pull request
Jan 29, 2014
|
I merged in your PR. Thanks @voidPirate . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.