Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options shortcut 'o' doesn't work for cryptocurrency #49

Closed
miraclx opened this issue Feb 6, 2021 · 3 comments · May be fixed by #94
Closed

Options shortcut 'o' doesn't work for cryptocurrency #49

miraclx opened this issue Feb 6, 2021 · 3 comments · May be fixed by #94

Comments

@miraclx
Copy link
Contributor

miraclx commented Feb 6, 2021

After seeing #34 & #37, I think, when you press o to view options for crypto, either a helpful dialog should be shown to the user or at least a note in the Help pane under the Toggle Options Pane section.
@miraclx miraclx mentioned this issue Feb 6, 2021
Merged
@miraclx miraclx changed the title Options shortcut 'o' don't work for cryptocurrency Options shortcut 'o' doesn't work for cryptocurrency Feb 6, 2021
@tarkah tarkah closed this as completed Feb 6, 2021
@miraclx
Copy link
Contributor Author

miraclx commented Feb 7, 2021

Hi again, so what do you think about implementing a pop-up dialog informing users about the unavailability of options for crypto?

@tarkah
Copy link
Owner

tarkah commented Feb 7, 2021

I'm not really sure it's necessary. The Toggle block doesn't have the Options 'o' item in it when on a crypto tab, plus you've now added a notice on the help page.

@miraclx
Copy link
Contributor Author

miraclx commented Feb 7, 2021

Oh. Just realized the toggle block doesn't include that. All good then.

@miraclx miraclx mentioned this issue Feb 24, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gray out options toggle on crypto miraclx/tickrs
2 participants
@tarkah @miraclx