Merge pull request #1885 from tarlepp/chore(tests)/improve-controller…

…-integration-tests Chore(tests) - Added JSON output asserts to controller integration tests
tarlepp · Aug 7, 2022 · 8b2b1dc · 8b2b1dc
2 parents 6ece9c4 + a7b5998
commit 8b2b1dc
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/tests/Integration/Controller/HealthzControllerTest.php b/tests/Integration/Controller/HealthzControllerTest.php
@@ -17,6 +17,7 @@
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Throwable;
+use function sprintf;
 
 /**
  * Class HealthzControllerTest
@@ -67,7 +68,7 @@ public function testThatInvokeMethodIsCallingExpectedMethods(): void
             ->willReturn(
                 new JsonResponse(
                     [
-                        'timestamp' => $healthz->getTimestamp(),
+                        'timestamp' => $healthz->getTimestamp()->format('c'),
                     ],
                 ),
             );
@@ -78,5 +79,12 @@ public function testThatInvokeMethodIsCallingExpectedMethods(): void
         self::assertSame(200, $response->getStatusCode());
         self::assertNotFalse($content);
         self::assertJson($content);
+        self::assertJsonStringEqualsJsonString(
+            sprintf(
+                '{"timestamp": "%s"}',
+                $healthz->getTimestamp()->format('c'),
+            ),
+            $content,
+        );
     }
 }
diff --git a/tests/Integration/Controller/IndexControllerTest.php b/tests/Integration/Controller/IndexControllerTest.php
@@ -30,5 +30,6 @@ public function testThatInvokeMethodReturnsExpectedResponse(): void
         self::assertSame(200, $response->getStatusCode());
         self::assertNotFalse($content);
         self::assertJson($content);
+        self::assertJsonStringEqualsJsonString('{}', $content);
     }
 }
diff --git a/tests/Integration/Controller/VersionControllerTest.php b/tests/Integration/Controller/VersionControllerTest.php
@@ -40,5 +40,6 @@ public function testThatInvokeMethodIsCallingExpectedMethods(): void
         self::assertSame(200, $response->getStatusCode());
         self::assertNotFalse($content);
         self::assertJson($content);
+        self::assertJsonStringEqualsJsonString('{"version": "1.0.0"}', $content);
     }
 }