Merge pull request #1832 from tarlepp/chore(test)/testdox-fixes

Chore(test) - Added missing dataproviders
tarlepp · May 29, 2022 · 8dd419e · 8dd419e
2 parents 84237a9 + e1ae533
commit 8dd419e
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 2 deletions.
diff --git a/tests/Integration/Entity/ApiKeyTest.php b/tests/Integration/Entity/ApiKeyTest.php
@@ -45,7 +45,9 @@ public function testThatApiKeyHasExpectedRoles(
         StringableArrayObject $expectedRoles,
         StringableArrayObject $criteria
     ): void {
-        $apiKey = self::getContainer()->get(ApiKeyRepository::class)->findOneBy($criteria->getArrayCopy());
+        static::bootKernel();
+
+        $apiKey = static::getContainer()->get(ApiKeyRepository::class)->findOneBy($criteria->getArrayCopy());
 
         self::assertInstanceOf(ApiKey::class, $apiKey);
         self::assertSame($expectedRoles->getArrayCopy(), $apiKey->getRoles());
@@ -57,7 +59,7 @@ public function testThatApiKeyHasExpectedRoles(
      */
     public function dataProviderTestThatApiKeyHasExpectedRoles(): Generator
     {
-        $rolesService = self::getContainer()->get(RolesService::class);
+        $rolesService = static::getContainer()->get(RolesService::class);
 
         foreach ($rolesService->getRoles() as $role) {
             yield [

diff --git a/tests/Integration/Entity/DateDimensionTest.php b/tests/Integration/Entity/DateDimensionTest.php
@@ -32,6 +32,8 @@ class DateDimensionTest extends EntityTestCase
 
     /** @noinspection PhpMissingParentCallCommonInspection */
     /**
+     * @dataProvider dataProviderTestThatSetterAndGettersWorks
+     *
      * @testdox No setter for `$property` property in read only entity - so cannot test this
      */
     public function testThatSetterOnlyAcceptSpecifiedType(
@@ -44,6 +46,8 @@ public function testThatSetterOnlyAcceptSpecifiedType(
 
     /** @noinspection PhpMissingParentCallCommonInspection */
     /**
+     * @dataProvider dataProviderTestThatSetterAndGettersWorks
+     *
      * @testdox No setter for `$property` property in read only entity - so cannot test this
      */
     public function testThatSetterReturnsInstanceOfEntity(

diff --git a/tests/Integration/Entity/LogLoginFailureTest.php b/tests/Integration/Entity/LogLoginFailureTest.php
@@ -32,6 +32,8 @@ class LogLoginFailureTest extends EntityTestCase
 
     /** @noinspection PhpMissingParentCallCommonInspection */
     /**
+     * @dataProvider dataProviderTestThatSetterAndGettersWorks
+     *
      * @testdox No setter for `$property` property in read only entity - so cannot test this
      */
     public function testThatSetterOnlyAcceptSpecifiedType(
@@ -44,6 +46,8 @@ public function testThatSetterOnlyAcceptSpecifiedType(
 
     /** @noinspection PhpMissingParentCallCommonInspection */
     /**
+     * @dataProvider dataProviderTestThatSetterAndGettersWorks
+     *
      * @testdox No setter for `$property` property in read only entity - so cannot test this
      */
     public function testThatSetterReturnsInstanceOfEntity(

diff --git a/tests/Integration/Entity/LogLoginTest.php b/tests/Integration/Entity/LogLoginTest.php
@@ -36,6 +36,8 @@ class LogLoginTest extends EntityTestCase
 
     /** @noinspection PhpMissingParentCallCommonInspection */
     /**
+     * @dataProvider dataProviderTestThatSetterAndGettersWorks
+     *
      * @testdox No setter for `$property` property in read only entity - so cannot test this
      */
     public function testThatSetterOnlyAcceptSpecifiedType(
@@ -48,6 +50,8 @@ public function testThatSetterOnlyAcceptSpecifiedType(
 
     /** @noinspection PhpMissingParentCallCommonInspection */
     /**
+     * @dataProvider dataProviderTestThatSetterAndGettersWorks
+     *
      * @testdox No setter for `$property` property in read only entity - so cannot test this
      */
     public function testThatSetterReturnsInstanceOfEntity(

diff --git a/tests/Integration/Entity/LogRequestTest.php b/tests/Integration/Entity/LogRequestTest.php
@@ -43,6 +43,8 @@ class LogRequestTest extends EntityTestCase
 
     /** @noinspection PhpMissingParentCallCommonInspection */
     /**
+     * @dataProvider dataProviderTestThatSetterAndGettersWorks
+     *
      * @testdox No setter for `$property` property in read only entity - so cannot test this
      */
     public function testThatSetterOnlyAcceptSpecifiedType(
@@ -55,6 +57,8 @@ public function testThatSetterOnlyAcceptSpecifiedType(
 
     /** @noinspection PhpMissingParentCallCommonInspection */
     /**
+     * @dataProvider dataProviderTestThatSetterAndGettersWorks
+     *
      * @testdox No setter for `$property` property in read only entity - so cannot test this
      */
     public function testThatSetterReturnsInstanceOfEntity(