Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "golang.org/x/sys/unix" instead of "syscall" (fix #59) #73

Merged
merged 1 commit into from Dec 15, 2017

Conversation

hnw
Copy link
Contributor

@hnw hnw commented Dec 14, 2017

According to the discussion on golang/go#18866, Termios from golang.org/x/sys/unix has better portability than syscall.Termios. So we should use it.

This PR works fine on mipsle.

@tarm tarm merged commit fdb95b5 into tarm:master Dec 15, 2017
@tarm
Copy link
Owner

tarm commented Dec 15, 2017

Thanks for the PR!

@nocko
Copy link

nocko commented Jan 12, 2018

This doesn't seem to fix #59. I have the same error (mipsle):

../vendor/github.com/tarm/serial/serial_linux.go:105:9: unknown field 'Ispeed' in struct literal of type syscall.Termios
../vendor/github.com/tarm/serial/serial_linux.go:106:9: unknown field 'Ospeed' in struct literal of type syscall.Termios

I don't see how it could work since Ispeed and Ospeed aren't in the struct on mips or mipsle, but are still referenced after this patch.

@tarm
Copy link
Owner

tarm commented Jan 14, 2018

@nocko (repeating this comment from #59...) I believe this is compiling as expected on mips. I just pushed a change to the travis.yml file that adds cross compile targets for arm, mips, and mipsle and those at least compile (I have not personally tested mips, but arm and x64 are in production).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants