Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid use of nested bin for yarn compatibility #32

Merged
merged 1 commit into from
Nov 11, 2016

Conversation

rgoldfinger
Copy link
Contributor

Yarn has different semantics for handling nested bins (i.e. it doesn't handle them). See yarnpkg/yarn#760. This makes this package compatible with yarn by avoiding the use of the bin.

@coveralls
Copy link

coveralls commented Nov 1, 2016

Coverage Status

Coverage remained the same at 95.146% when pulling b65f1bc on rgoldfinger:yarn-compatibility into 069d80a on tarmolov:master.

@tarmolov
Copy link
Owner

tarmolov commented Nov 1, 2016

It seems that it's a yarn bug and the pr yarnpkg/yarn#1210 should fix it.
It's better to wait a little.

@rgoldfinger
Copy link
Contributor Author

From my reading, hoisting binaries has questionable semantics that the yarn authors are not eager to support, and that PR seems to be going nowhere. Since it's easy enough to avoid relying on this feature of npm, I'm hoping that you'll be open to avoiding it and making this package compatible with yarn.

Thank you, by the way, for the great package. We rely on it heavily and are holding off on yarn because we don't want to lose it.

@rjmunro
Copy link
Contributor

rjmunro commented Nov 2, 2016

IMHO, unless there is reason for the user to call the node_modules/.bin/git-hooks script directly from time to time, it seems wrong to include it in the bin section of package.json.

@tarmolov tarmolov merged commit ead2287 into tarmolov:master Nov 11, 2016
@tarmolov
Copy link
Owner

Just published 1.1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants