Use git rev-parse --git-dir to find a git dir #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmunro
force-pushed
the
feature/parse-git-dir
branch
from
0e07073
to
f229dfe
Compare
rjmunro
force-pushed
the
feature/parse-git-dir
branch
from
f229dfe
to
be3a4f8
Compare
rjmunro
force-pushed
the
feature/parse-git-dir
branch
from
be3a4f8
to
aa4d10e
Compare
rjmunro
force-pushed
the
feature/parse-git-dir
branch
from
aa4d10e
to
4b1ac7c
Compare
|
@tarmolov This should be ready to merge. It's failing coveralls because it adds one more uncovered line, which is a throw statement that happens if there is an unknown error. I don't know how to fake the kind of error, so I can't write tests for it. Something like git not being installed, or trying to install in a folder that doesn't exist might do it - I'm not sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by @Kampfgnom's work, but using execSync to simplify things a lot.
This fixes #48, meaning that hooks will be installed if the project is a submodule.