WIP: save data with --xfail / -x #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `-x` to abort the test run on the first failure, pytest-testmon would previously not store the collected data: the `pytest_keyboard_interrupt` hook that is used for this gets also called for pytest's internal `Interrupted` exception, which is a subclass of `KeyboardInterrupt` (pytest-dev/pytest#1865). This patch changes it to use the result in the `pytest_runtest_protocol` method to check for `KeyboardInterrupt` there explicitly. This makes the `pytest_keyboard_interrupt` obsolete, but I've left it with some asserts for now.
Also handle pytest-watch sending SIGINT.
|
Thanks for merging - should have been squashed though. With GitHub just use the squash-merge option from the UI if it should be one commit (like in this case). |
tarpas
added a commit
that referenced
this pull request
Dec 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
-xto abort the test run on the first failure,pytest-testmon would previously not store the collected data: the
pytest_keyboard_interrupthook that is used for this gets also calledfor pytest's internal
Interruptedexception, which is a subclass ofKeyboardInterrupt(pytest-dev/pytest#1865).This patch changes it to use the result in the
pytest_runtest_protocolmethod to check for
KeyboardInterruptthere explicitly.This makes the
pytest_keyboard_interruptobsolete, but I've left itwith some asserts for now.