-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for tartiflette-starlette #230
Comments
Thank you @florimondmanca I will have a look at it next week. |
Thought: Might want to just call it |
Fair point @tomchristie. tartiflette-asgi was the initial name, but seeing how much confusion the current seems to bring wrt to the Starlette dependency (“My framework is not based on Starlette so I can’t use this, right?”), I’d also be keen to revert. (As for Sanic, someone’s trying out Sanic + tartiflette-starlette right now, but from at first glance it seems that Sanic misses the ASGI sub-mounting that allows integrating with other frameworks.) @tsunnamis To catch up, has there been any progress I haven’t seen on documenting tartiflette-starlette in the official docs? |
What's the status and is there anything I can help with on this? |
@AutumnalDream I don't think there has been progress since the opening of this issue. Hints on how to contribute docs are here. I think the first step would be to rephrase the highlight on the landing page, e.g.: ### aiohttp / ASGI
In addition to the Tartiflette engine,
`tartiflette-aiohttp` and `tartiflette-starlette` allow you to
serve your GraphQL API over HTTP. |
@florimondmanca Hello, we didn't work on it. Do not hesitate to contribute to the documentation by creating a pull-request on tartiflette.io. |
Request a feature
The ASGI adapter for Tartiflette is being developer at https://github.com/tartiflette/tartiflette-starlette.
We discussed adding documentation for
tartiflette-starlette
alongsidetartiflette-aiohttp
— see tartiflette/tartiflette-asgi#19 (comment).A pre-requisite to this is to achieve feature parity between both packages (see tartiflette/tartiflette-asgi#20).
This issue is mostly here to track this task somewhere. :-) I will probably start working on it once feature parity has been rolled out.
The text was updated successfully, but these errors were encountered: