Skip to content

Commit

Permalink
Update release checklist
Browse files Browse the repository at this point in the history
(no need to git push twice in succession)

Also: twine uploads now use '--repository' args of colorama and
colorama-test, which need defining in .pypirc. Making project-specific
repo entries like this allows me to use a project-specific token
from pypi, rather than one that grants all privs to every project.

Also: bump version number of 0.4.7dev1
  • Loading branch information
tartley committed Oct 25, 2022
1 parent 3de9f01 commit 6f03975
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 16 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -58,5 +58,5 @@ test-release: build ## Test a built release
.PHONY: test-release

release: ## Upload a built release
$(twine) upload dist/colorama-*
$(twine) upload --repository=colorama dist/colorama-*
.PHONY: release
22 changes: 9 additions & 13 deletions README-hacking.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,16 +97,12 @@ target.
git tag -a -m "" $version
git push --follow-tags

6. Push to origin (This triggers a CI build, which we'll check later on)

git push origin master

7. Build the distributables (sdist and wheel), on either OS:
6. Build the distributables (sdist and wheel), on either OS:

* Windows: `.\build.ps1`
* Linux: `make build`

8. Test the distributables on both OS. Whichever one you do 2nd will get an
7. Test the distributables on both OS. Whichever one you do 2nd will get an
HTTP 400 response on uploading to test.pypi.org, but outputs a message
saying this is expected and carries on:

Expand All @@ -116,27 +112,27 @@ target.
(This currently only tests the wheel, but
[should soon test the sdist too](https://github.com/tartley/colorama/issues/286).)

9. Check the [CI builds](https://github.com/tartley/colorama/actions/)
8. Check the [CI builds](https://github.com/tartley/colorama/actions/)
are complete and all passing.

10. Upload the distributables to PyPI:
9. Upload the distributables to PyPI:

* On Windows: `.\release.ps1`
* On Linux: `make release`

11. Test by installing the candidate version from PyPI, and sanity check it with
10. Test by installing the candidate version from PyPI, and sanity check it with
'demo.sh', making sure this is running against the PyPI installation, not
local source.

12. Maybe wait a day for anyone using pre-release installs to report any
11. Maybe wait a day for anyone using pre-release installs to report any
problems?

13. Remove the '.rcX' suffix from `__version__` in
12. Remove the '.rcX' suffix from `__version__` in
`colorama/__init__.py`.

14. Repeat steps 4 to 10, for the actual (non-candidate) release.
13. Repeat steps 4 to 9, for the actual (non-candidate) release.

15. Bump the version number in `colorama/__init__.py`, and add a 'dev1'
14. Bump the version number in `colorama/__init__.py`, and add a 'dev1'
suffix, eg:

`0.4.5dev1`
Expand Down
2 changes: 1 addition & 1 deletion colorama/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
from .ansi import Fore, Back, Style, Cursor
from .ansitowin32 import AnsiToWin32

__version__ = '0.4.6'
__version__ = '0.4.7dev1'

2 changes: 1 addition & 1 deletion test-release
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ bin="$HOME/.virtualenvs/colorama/bin"
sandbox=test-release-playground

# Upload to the test PyPI.
$bin/twine upload --repository testpypi dist/colorama-* \
$bin/twine upload --repository colorama-test dist/colorama-* \
|| echo " > Expect a 400 if package was already uploaded."

# cd elsewhere so we cannot import from local source.
Expand Down

0 comments on commit 6f03975

Please sign in to comment.