Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why no tar.gz/source distributable for 0.4.4 ? #284

Closed
SomberNight opened this issue Oct 15, 2020 · 2 comments
Closed

why no tar.gz/source distributable for 0.4.4 ? #284

SomberNight opened this issue Oct 15, 2020 · 2 comments

Comments

@SomberNight
Copy link

Previous releases, such as 0.4.3 had both a wheel and a tar.gz/zip source distributable.
0.4.4 only has a wheel uploaded to PyPI.

Compare:
https://pypi.org/project/colorama/0.4.3/#files
https://pypi.org/project/colorama/0.4.4/#files

This breaks pip install --no-binary :all:, e.g. as used here:
https://github.com/spesmilo/electrum/blob/9bc4182924424bab2b1c11ef1e9c7f32ab6f2922/contrib/make_packages#L9-L10

SomberNight added a commit to spesmilo/electrum that referenced this issue Oct 15, 2020
until tartley/colorama#284 is resolved

colorama 0.4.4 does not have a source dist uploaded to PyPI, which breaks contrib/make_packages

this partially reverts 4d0afff
@tartley
Copy link
Owner

tartley commented Oct 15, 2020

Thanks for reporting. I'll fix it today, and add this to the new 'releases checklist', so we can be more reliable about stuff like this.

tartley added a commit that referenced this issue Oct 15, 2020
@tartley
Copy link
Owner

tartley commented Oct 15, 2020

I've been automating the release process recently, to try and make it more reliable, and I had a bug in the new release scripts, that omitted the source distributions from the upload. Fixed now: e0a314e

And I manually uploaded the 0.4.4 sdist. Should be working now.

@tartley tartley closed this as completed Oct 15, 2020
reddink pushed a commit to reddcoin-project/electrum-redd that referenced this issue Nov 10, 2020
until tartley/colorama#284 is resolved

colorama 0.4.4 does not have a source dist uploaded to PyPI, which breaks contrib/make_packages

this partially reverts 4d0afff

(cherry picked from commit 695ad75)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants