Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add light colors in README #100

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Add light colors in README #100

merged 1 commit into from
Oct 7, 2021

Conversation

Timokasse
Copy link
Contributor

Let's not hide those in the dark of the code.

@wiggin15
Copy link
Collaborator

Hiding these colors from the documentation was intentional. Since they are not part of the standard, it is not recommended to use them, and using AnsiStyle.BRIGHT is a better idea. The EX colors are there more because we want colorama to know how to convert them to Windows API calls if they are used, but they should not really be used in the code. See #20.

I'm open to other opinions, though, if you still think it should be documented.

@Timokasse
Copy link
Contributor Author

If there is a better way, I am all for it. But I tried and I don't see how I could do a
print(Fore.LIGHTRED_EX + 'some light red text')
with standard colors.

Also, I have specified that these colors are not part of the standard because I believe it is best to provide accurate information. And since it works on Linux and Cygwin (Windows) at least, I am convinced it could be useful to many.

@tartley
Copy link
Owner

tartley commented Oct 13, 2020

Hey. FYI, yesterday I created a PR to test releases before we push them to PyPI. When that is merged, I'll be more confident about resuming merges and releases. I'll try to look at this PR soon. Thank you for creating it!

@Timokasse
Copy link
Contributor Author

My commit is only updating the README. So there is not much chance it breaks something important anyway. ;-)

@tartley tartley merged commit 34703ec into tartley:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants