-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.10 #321
Conversation
hugovk
commented
Oct 7, 2021
This is brilliant, huge thanks. I just added an issue to this effect 30 seconds ago, then saw you'd already submitted this. Thank you! I want to merge it immediately. Before I do, can you indulge me by getting me up to speed on the syntax of the travis file:
Am I right to infer that you had to add quotes for the "3.10-dev", so you thought you'd add quotes to all entries, to be consistent? That seems sensible. Does the above mean that for arm64 and amd64, we test on python3.7? Presumably that was the latest at the time those lines were written. Should we update it? To python 3.10-dev? Or to python 3.9? What architecture do all the other python versions get tested on? |
Ah, I just saw (and merged) your other branch to switch from Travis to github actions. https://github.com/tartley/colorama/pull/322/files I see it includes python3.10 in the tests it runs. Am I right that this PR no longer needs to be merged? |
I added quotes because of a special case for Python 3.10. In YAML, if you put More info: https://dev.to/hugovk/the-python-3-1-problem-85g Of course, we don't need to worry about deleting
Yes.
They were added in #253, 3.8 was the latest at that time. #248 is discussion. GitHub Actions doesn't have any native arm64 support.
Testing a single version is probably enough. Do we still need to test on arm64? If so, one solution is to get Travis back up and running for this repo and just test arm64 there. Another option is to use Docker on GitHub Actions and emulate arm64. Ping also @ossdev07 who contributed the PR mentioned above.
The default Travis architecture is AMD64 architecture ( https://docs.travis-ci.com/user/reference/overview/#for-a-particular-travisyml-configuration GitHub Actions are also amd64. |
The README, tox.ini and setup.py changes are still useful, I'll rebase! |
Rebased! |
You are amazing, many thanks, merging... |